[
Thread Prev][
Thread Next] >
Date Index
>
Thread Index
Re: [wmx] Manager::spawn()
Lasse Rasinen -
Wed Jan 31 01:21:12 2001
Lasse Rasinen <lrasinen@iki.fi> writes:
> --- Manager.C.old Wed Jan 31 01:51:33 2001
> +++ Manager.C Wed Jan 31 01:57:57 2001
> @@ -941,9 +941,8 @@
> char *pstring = (char *)malloc(strlen(displayName) + 11 +
> numdigits(screen()));
> sprintf(pstring, "DISPLAY=%s", displayName);
> - for(c=pstring; *c && (*c != '.'); c++);
> - *(c++)='.';
> - sprintf(c, "%d", screen());
> + c = strrchr(pstring, '.');
> + sprintf(c + 1, "%d", screen());
> putenv(pstring);
> }
Ignore that, I'm getting sloppy ;(, of course I should check for a null
pointer even if the dot will be there, just in case it isn't ;)
--- Manager.C.old Wed Jan 31 01:51:33 2001
+++ Manager.C Wed Jan 31 02:16:21 2001
@@ -941,10 +941,11 @@
char *pstring = (char *)malloc(strlen(displayName) + 11 +
numdigits(screen()));
sprintf(pstring, "DISPLAY=%s", displayName);
- for(c=pstring; *c && (*c != '.'); c++);
- *(c++)='.';
- sprintf(c, "%d", screen());
- putenv(pstring);
+ c = strrchr(pstring, '.');
+ if (c) {
+ sprintf(c + 1, "%d", screen());
+ putenv(pstring);
+ }
}
if (CONFIG_EXEC_USING_SHELL) {
--
Lasse Rasinen
lrasinen@iki.fi
Next: