[Thread Prev][Thread Next]   >Date Index >Thread Index

[wmx] fix for shaped windows patch

henri - Wed Jul 28 08:24:14 1999


ok, i don't really understand why/how this all works...

but if you are using the shaped windows patch you will want to apply this patch:
(the latest tarball on <http://www.nidal.com/~henri/wmx> has this fix)

+++++++++++++++++++++++++

Index: Border.C
===================================================================
RCS file: /cvs/master/wmx/Border.C,v
retrieving revision 1.2
retrieving revision 1.3
diff -r1.2 -r1.3
323,326c323,324
<       recs =  XShapeGetRectangles(display(), m_child, ShapeClip, &count, &ordering);
<       XShapeCombineRectangles
<           (display(), m_parent, ShapeClip, xIndent(), yIndent(),
<            recs, count, ShapeSet, ordering);
---
> //      count me among the clueless... i have no idea why
> //      this code is not needed....
328c326,331
<       XFree(recs);
---
> //    recs =  XShapeGetRectangles(display(), m_child, ShapeClip, &count, &ordering);
> //    XShapeCombineRectangles
> //        (display(), m_parent, ShapeClip, xIndent(), yIndent(),
> //         recs, count, ShapeSet, ordering);
> 
> //    XFree(recs);


+++++++++++++++++++++++++++

just save it to a file (border.diff) and in your wmx code directory run

patch -strip < border.diff

then just run make.

this fixes the bug that would happen when xmms (x11amp) or GQMpeg (or
anything else that uses shaped windows) would change their shape (xmms
just becomes the single bar, you change skin w/ GQMpeg)

i guess i'm just a happy-go-lucky hacker, since i have no clue why
commenting out the 4 lines of code fixes the problem (or why the
problem occured in the first place). i was totally stuck, had added
tons of code, not gotten anywhere, then decided to start removing code
to see what would break (and get an idea of what was really going on),
first thing i commented out fixed the problem! went back and deleted
all the code i added.. :)

henri


Next: