Re: [wmx] Wmx Bug

Jerronimo <sdlpci@cis.rit.edu> writes:

> I managed to reproduce this one accidently about twice now.  Netscape 
> runs pretty slow on our machines here. so if i close netscape, then
> bring up the WMX menu (left button) before netscape (or any other app) 
> goes away, and wait for it to go away, then move the mouse over the menu 
> item for the window that doesn't exist anymore, and wmx crashes.
> 
> 1: close a window that takes a while to close
> 2: before it disappears bring up the window menu (left button)
> 3: wait for the window to disappear
> 4: select it in the window menu
> 5: wmx crashes

Found and fixed (I hope). This patch seems to fix the bug and looks like
nothing is broken.

I used "rxvt -e sleep 3" to reproduce the bug, so you might try it too.

--- Menu.C.old  Thu Jan 28 14:29:33 1999
+++ Menu.C      Tue Mar 16 20:17:10 1999
@@ -465,7 +465,15 @@
     if (selecting > 0) {
        
        Client *cl = m_clients.item(selecting - 1);
-           
+
+       Boolean found = False;
+       for (int i = 0; i < m_windowManager->clients().count(); i++)
+           if (cl == m_windowManager->clients().item(i))
+               found = True;
+
+       if (!found)
+           return;
+               
        if (selecting < m_nHidden) cl->unhide(True);
        else if (selecting < m_nItems) {