Re: [wmx] wmx tarball

Sven Oliver Moll <smol0999@rz.uni-hildesheim.de> writes:

> wmx-5sec3pl4.tar.gz has two more modifications:
> - make distclean now also removes the files created by ./configure
> - quick channel surf is now only <MOD>F1 - <MOD>F10 not <MOD>F1 - <MOD>F12

Mrrm. Why do the needs of Sun outweight the needs of many? All other
keyboards have no such limitations, and I dislike the idea of one
architecture taking the rest hostage, so to speak.

> BTW: My dynamic keyboard config bloated wmx by >20% so I tilted that, and use
> two diffrent binaries (one for SunKeys, the other for PCKeys) and a wrapper
> (not coded yet).

I use something like the following in my .xsession

case `uname` in
    IRIX) bin/wmx ;;
    SunOS) wmx-5/a.out ;;
    *) xterm ;; # You lose
esac

Maybe something similar would work too?

Anyway, if people do want those quicky buttons, then maybe something like
the patch in the end. (The #define was named in a whim, don't take it
personally ;)

PS. Does someone have an older HP-UX, who could tell whether the #define
    select(...) in Events.C, line 163 is necessary. HP-UX 11.00 complains
    about it, and loudly, so maybe it's outdated?

--- Config.h.old	Wed Feb 10 18:59:56 1999
+++ Config.h	Wed Feb 10 19:04:21 1999
@@ -175,6 +175,7 @@
 #define CONFIG_USE_KEYBOARD       (dConfig.useKeyboard())
 #define DEFAULT_USE_KEYBOARD      1
 // 1 = Keyboard on
+#define CONFIG_USE_BLOODY_SUN_KEYS False
 
 // This is a keyboard modifier mask as defined in <X11/X.h>.  It's the
 // modifier required for wm controls: e.g. Alt/Left and Alt/Right to
--- Buttons.C.old	Wed Feb 10 18:59:03 1999
+++ Buttons.C	Wed Feb 10 19:08:19 1999
@@ -99,36 +99,39 @@
 
 	Client *c = windowToClient(ev->window);
 
-	if (key == CONFIG_QUICKRAISE_KEY && c) {
+	if (CONFIG_USE_BLOODY_SUN_KEYS) {
+	    if (key == CONFIG_QUICKRAISE_KEY && c) {
 
-	    if (isTop(c) && (CONFIG_QUICKRAISE_ALSO_LOWERS == True)) {
-		c->lower();
-	    } else {
-		c->mapRaised();
+		if (isTop(c) && (CONFIG_QUICKRAISE_ALSO_LOWERS == True)) {
+		    c->lower();
+		} else {
+		    c->mapRaised();
+		}
+
+	    } else if (key == CONFIG_QUICKHIDE_KEY && c) {
+		c->hide();
+
+	    } else if (key == CONFIG_QUICKHEIGHT_KEY && c) {
+
+		if (c->isFullHeight()) {
+		    c->normalHeight();
+		} else {
+		    c->fullHeight();
+		}
+
+	    } else if ((key == CONFIG_QUICKCLIENT_MENU_KEY && c)
+		       && CONFIG_WANT_KEYBOARD_MENU) {
+		ClientMenu menu(this, (XEvent *)ev);
+
+	    } 
+	    else if ((key == CONFIG_QUICKCOMMAND_MENU_KEY && c)
+		     && CONFIG_WANT_KEYBOARD_MENU) {
+		CommandMenu menu(this, (XEvent *)ev);
 	    }
-
-	} else if (key == CONFIG_QUICKHIDE_KEY && c) {
-	    c->hide();
-
-	} else if (key == CONFIG_QUICKHEIGHT_KEY && c) {
-
-	    if (c->isFullHeight()) {
-		c->normalHeight();
-	    } else {
-		c->fullHeight();
-	    }
-
-	} else if ((key == CONFIG_QUICKCLIENT_MENU_KEY && c)
-		   && CONFIG_WANT_KEYBOARD_MENU) {
-	    ClientMenu menu(this, (XEvent *)ev);
-
-	} else if ((key == CONFIG_QUICKCOMMAND_MENU_KEY && c)
-		   && CONFIG_WANT_KEYBOARD_MENU) {
-	    CommandMenu menu(this, (XEvent *)ev);
 	    
 	} else if (ev->state & CONFIG_ALT_KEY_MASK) {
 
-	    if (key >= XK_F1 && key <= XK_F10 &&
+	    if (key >= XK_F1 && key <= XK_F12 &&
 		CONFIG_CHANNEL_SURF && CONFIG_USE_CHANNEL_KEYS) {
 
 		int channel = key - XK_F1 + 1;