[Thread Prev][Thread Next]   >Date Index >Thread Index

Re: [wmx] Hi

Damion Yates - Tue May 13 19:07:49 2003

On Tue, 13 May 2003, Frank Ch. Eigler wrote:

> > here a little bit broblem on make....
> >
> > c++ -c -g -O2 -I/usr/X11R6/include Menu.C
> > Menu.C:625: default argument given for parameter 3 of `
> >    CommandMenu::CommandMenu(WindowManager*, XEvent*, char* = 0)'
> > Menu.h:92: after previous specification in `
> >    CommandMenu::CommandMenu(WindowManager*, XEvent*, char* = 0)'
> > [...]
> Sure.  In C++, only the declaration should give default arguments.
> The definition (in the .C file) should not.

I apply a quick patch against the live code on newly built boxes.  I've also
noticed the same from a recent play with FreeBSD and the ports collection.

My patch includes a few quick lines based on work I did on Alt-click
dragging, seriously tidied up by Teemu Voipio.  This is a minor addition to
the bare-ness of wmx and I'd argue should be in the main code.  It's almost a
requirement for moving popup windows with no main title bar to grab.

The patch also lowers some usleep values designed for 199* machines with slow
X so it doesn't load the box.  Lowering the delays used when dragging windows
around makes wmx look MUCH smoother and more like most other window managers.

It sets a few more sane values in Config.H ("xterm" rather than
"/home/chris/.wmx/Terminal" if I recall for example).

It also fixes the bug mentioned in this thread.

It's not inconvenient for me to store this patch somewhere save and apply it
on recently downloaded copies of the base 6.0 (IIRC) release.  But surely
this 80 lines or so could be added for a 6.1 more tidy version?

At the very minimum surely the one for download shouldn't contain the bug
shown up in the more strict gcc 3.2 series compiler?


Damion Yates - Maiden House, Vanwall Business estate, Maidenhead
email: Damion.Yates@bbc.co.uk - phone: +44 (0) 1628 407759 (or ex: 37759)